justin/jsix_import
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

[util] Remove enum_bitfields

Browse Source 
The enum_bitfields system never worked quite right, and always had edge cases where name
resolution for the SFINAE would fail. Move everything over to use util::bitset, which can
be constexpr and boils down to inline integer bitops in release mode.

Improved util::bitset itself, moving the array-backed base implementation into a new
util::sized_bitset, and making the single-inttype backed implementation the base case.
Also added a distinction between | or |= (which work with real bit values) and + or +=
(which work with bit indexes).
This commit is contained in:
Justin C. Miller
2024-02-25 23:40:14 -08:00
parent f7ea46e49e
commit 9f54927a82
36 changed files with 352 additions and 622 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/kernel/apic.cpp
View File

@@ -71,21 +71,19 @@ lapic::get_id()
}
void
lapic::send_ipi(ipi mode, isr vector, uint8_t dest)
lapic::send_ipi(util::bitset32 mode, isr vector, uint8_t dest)
{
// Wait until the APIC is ready to send
ipi_wait();
uint32_t command =
static_cast<uint32_t>(vector) |
static_cast<uint32_t>(mode);
uint32_t command = util::bitset32::from(vector) | mode;
apic_write(m_base, lapic_icr_high, static_cast<uint32_t>(dest) << 24);
apic_write(m_base, lapic_icr_low, command);
}
void
lapic::send_ipi_broadcast(ipi mode, bool self, isr vector)
lapic::send_ipi_broadcast(util::bitset32 mode, bool self, isr vector)
{
// Wait until the APIC is ready to send
ipi_wait();