[kernel] Make grabbing an IST stack atomic

In the beginning of the interrupt handler, we had previously checked if
the current handler had grabbed an IST stack from the IDT/TSS. If it
was, it saved this value and set it to 0 in the IDT, then restored it at
the end.

Now this is an atomic action. This is unlikely to make a difference
unless the interrupt handler is itself interrupted by an exception
before being able to swap the IDT value, but such a situation is now
impossible.

src/kernel/idt.h

@@ -2,6 +2,7 @@
 /// \file idt.h
 /// Definitions relating to a CPU's IDT table
 #include <stdint.h>
+#include "assert.h"
 
 class IDT
 {
@@ -23,17 +24,30 @@ public:
     /// stacks can be created.
     void add_ist_entries();
 
-    /// Get the IST entry used by an entry.
+    /// Get the IST entry used by an entry, clearing it in the process.
     /// \arg i   Which IDT entry to look in
     /// \returns The IST index used by entry i, or 0 for none
-    inline uint8_t get_ist(uint8_t i) const {
-        return m_entries[i].ist;
+    inline uint8_t get_ist(uint8_t i) {
+        return __atomic_exchange_n(&m_entries[i].ist, 0, __ATOMIC_SEQ_CST);
     }
 
-    /// Set the IST entry used by an entry.
+    /// Restore the IST entry used by an entry when done using it.
+    /// \arg i   Which IDT entry to restore
+    /// \arg ist The IST index for entry i, or 0 for none
+    inline void return_ist(uint8_t i, uint8_t ist) {
+        if (!ist) return;
+        uint8_t expected = 0;
+        bool result = __atomic_compare_exchange_n(
+                &m_entries[i].ist, &expected, ist,
+                false, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST);
+        kassert(result, "Tried to overwrite a non-zero IST value in IDT");
+    }
+
+    /// Set the IST entry used by an entry. This should not be called
+    /// by interrupt handlers.
     /// \arg i   Which IDT entry to set
     /// \arg ist The IST index for entry i, or 0 for none
-    void set_ist(uint8_t i, uint8_t ist) { m_entries[i].ist = ist; }
+    inline void set_ist(uint8_t i, uint8_t ist) { m_entries[i].ist = ist; }
 
     /// Get the IST entries that are used by this table, as a bitmap
     static uint8_t used_ist_entries();

src/kernel/interrupts.cpp

@@ -75,8 +75,6 @@ isr_handler(cpu_state *regs)
     // this stack
     IDT &idt = IDT::current();
     uint8_t old_ist = idt.get_ist(vector);
-    if (old_ist)
-        idt.set_ist(vector, 0);
 
     char message[200];
 
@@ -165,7 +163,7 @@ isr_handler(cpu_state *regs)
 
     // Return the IST for this vector to what it was
     if (old_ist)
-        idt.set_ist(vector, old_ist);
+        idt.return_ist(vector, old_ist);
     *reinterpret_cast<uint32_t *>(apic_eoi_addr) = 0;
 }