justin/jsix_import
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

[kernel] Remove bitmask check in heap free

Browse Source 
Since all memory regions start with a header, this check should never
pass.
This commit is contained in:
Justin C. Miller
2021-02-02 18:37:23 -08:00
parent 4985b2d1f4
commit 33ed95bd8e
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/libraries/kutil/heap_allocator.cpp
View File

@@ -100,9 +100,8 @@ heap_allocator::free(void *p)
{ {
if (!p) return; if (!p) return;
static constexpr uintptr_t bad_mask = (1 << min_order) - 1;
uintptr_t addr = reinterpret_cast<uintptr_t>(p); uintptr_t addr = reinterpret_cast<uintptr_t>(p);
kassert(addr >= m_start && addr < m_end && !(addr & bad_mask), kassert(addr >= m_start && addr < m_end,
"Attempt to free non-heap pointer"); "Attempt to free non-heap pointer");
mem_header *header = reinterpret_cast<mem_header *>(p); mem_header *header = reinterpret_cast<mem_header *>(p);