From 2d6987341cd43e47728410b1cbc8f8086a091117 Mon Sep 17 00:00:00 2001 From: "Justin C. Miller" Date: Fri, 19 Feb 2021 21:47:46 -0800 Subject: [PATCH] [kernel] Make sure not to log from AP idle threads The idle threads for the APs have intentionally tiny stacks. Logging is currently an absolute hog of stack space, so avoid logging on the idle stacks as much as possible. Eventually we should instead just reclaim the physical pages used by most of the stack instead of making them tiny. --- src/kernel/apic.cpp | 1 - src/kernel/scheduler.cpp | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/kernel/apic.cpp b/src/kernel/apic.cpp index a3b7574..35d9f3e 100644 --- a/src/kernel/apic.cpp +++ b/src/kernel/apic.cpp @@ -62,7 +62,6 @@ lapic::lapic(uintptr_t base) : { apic_write(m_base, lapic_lvt_error, static_cast(isr::isrAPICError)); apic_write(m_base, lapic_spurious, static_cast(isr::isrSpurious)); - log::info(logs::apic, "LAPIC created, base %lx", m_base); } uint8_t diff --git a/src/kernel/scheduler.cpp b/src/kernel/scheduler.cpp index 4baff62..4156fc2 100644 --- a/src/kernel/scheduler.cpp +++ b/src/kernel/scheduler.cpp @@ -102,7 +102,6 @@ scheduler::start() process *kp = &process::kernel_process(); thread *idle = thread::create_idle_thread(*kp, max_priority, cpu.rsp0); - log::debug(logs::task, "CPU%02x idle thread koid %llx", cpu.index, idle->koid()); auto *tcb = idle->tcb(); cpu.process = kp; @@ -111,7 +110,6 @@ scheduler::start() queue.current = tcb; - log::info(logs::sched, "CPU%02x starting scheduler", cpu.index); cpu.apic->enable_timer(isr::isrTimer, false); cpu.apic->reset_timer(10); }