justin/jsix
1
1
Fork 0
mirror of https://github.com/justinian/jsix.git synced 2025-12-10 00:14:32 -08:00
Code Issues Packages Projects Releases Wiki Activity

[tools] Fix gdb j6bt & j6stack commands

Browse Source 
These commands had a number of issues. They weren't evaluating their
arguments (eg, you couldn't use a symbol name instead of a number), and
they weren't explicitly using hex when evaluating numbers, so they were
getting incorrect values when the default radix was not 10.
This commit is contained in:
Justin C. Miller
2022-01-15 09:01:03 -08:00
parent b3aaddadc8
commit 5c82e5ba1b
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
assets/debugging/jsix.elf-gdb.py
View File

@@ -10,6 +10,7 @@ class PrintStackCommand(gdb.Command):
base = "$rsp" base = "$rsp"
if len(args) > 0: if len(args) > 0:
base = args[0] base = args[0]
base = int(gdb.parse_and_eval(base))
depth = 22 depth = 22
if len(args) > 1: if len(args) > 1:
@@ -18,9 +19,8 @@ class PrintStackCommand(gdb.Command):
for i in range(depth-1, -1, -1): for i in range(depth-1, -1, -1):
try: try:
offset = i * 8 offset = i * 8
base_addr = gdb.parse_and_eval(base) value = gdb.parse_and_eval(f"*(uint64_t*)({base:#x} + {offset:#x})")
value = gdb.parse_and_eval(f"*(uint64_t*)({base} + 0x{offset:x})") print("{:016x} (+{:04x}): {:016x}".format(base + offset, offset, int(value)))
print("{:016x} (+{:04x}): {:016x}".format(int(base_addr) + offset, offset, int(value)))
except Exception as e: except Exception as e:
print(e) print(e)
continue continue
@@ -33,18 +33,18 @@ class PrintBacktraceCommand(gdb.Command):
def invoke(self, arg, from_tty): def invoke(self, arg, from_tty):
args = gdb.string_to_argv(arg) args = gdb.string_to_argv(arg)
depth = 30
if len(args) > 0:
depth = int(args[0])
frame = "$rbp" frame = "$rbp"
if len(args) > 1: if len(args) > 0:
frame = args[1] frame = args[0]
frame = gdb.parse_and_eval(f"{frame}") frame = int(gdb.parse_and_eval(f"{frame}"))
depth = 30
if len(args) > 1:
depth = int(gdb.parse_and_eval(args[1]))
for i in range(depth-1, -1, -1): for i in range(depth-1, -1, -1):
ret = gdb.parse_and_eval(f"*(uint64_t*)({frame} + 0x8)") ret = gdb.parse_and_eval(f"*(uint64_t*)({frame:#x} + 0x8)")
name = "" name = ""
try: try:
@@ -56,7 +56,7 @@ class PrintBacktraceCommand(gdb.Command):
print("{:016x}: {:016x} {}".format(int(frame), int(ret), name)) print("{:016x}: {:016x} {}".format(int(frame), int(ret), name))
frame = gdb.parse_and_eval(f"*(uint64_t*)({frame})") frame = int(gdb.parse_and_eval(f"*(uint64_t*)({frame:#x})"))
if frame == 0 or ret == 0: if frame == 0 or ret == 0:
return return